On 14 March 2014 18:22, Rob Herring <robherri...@gmail.com> wrote:
> From: Rob Herring <rob.herr...@linaro.org>
>
> When setting the fifo trigger level, the rx interrupt needs to be asserted
> if the current fifo level matches. This is more for correctness as the
> level is currently never changed.
>
> Signed-off-by: Rob Herring <rob.herr...@linaro.org>
> ---
> hw/char/pl011.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/hw/char/pl011.c b/hw/char/pl011.c
> index 5e664f4..3903933 100644
> --- a/hw/char/pl011.c
> +++ b/hw/char/pl011.c
> @@ -131,6 +131,10 @@ static void pl011_set_read_trigger(PL011State *s)
> else
> #endif
> s->read_trigger = 1;
> +
> + if (s->read_count == s->read_trigger) {
> + s->int_level |= PL011_INT_RX;
> + }
>=, surely?
Also if you're updating int_level then you need to call
pl011_update().
thanks
-- PMM
