On 03/10/2014 12:43 PM, Michael S. Tsirkin wrote: > it's a handy API for cases where we want to > get size in bits as a parameter. > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > --- > include/qemu/bswap.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h > index 0cb7c05..4489ad9 100644 > --- a/include/qemu/bswap.h > +++ b/include/qemu/bswap.h > @@ -423,9 +423,4 @@ static inline unsigned long leul_to_cpu(unsigned long v) > #endif > } > > -#undef le_bswap > -#undef be_bswap > -#undef le_bswaps > -#undef be_bswaps
I don't like this because the bits "as parameter" must be constant in order for token pasting to work. Better to just use the existing function calls. r~