"Gonglei (Arei)" <arei.gong...@huawei.com> wrote: >> On 03/11/2014 06:53 AM, arei.gong...@huawei.com wrote: >> > From: ChenLiang <chenlian...@huawei.com> >> > >> > Add counters to log the times of updating the dirty bitmap. >> > >> > Signed-off-by: ChenLiang <chenlian...@huawei.com> >> > Signed-off-by: Gonglei <arei.gong...@huawei.com> >> > Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com> >> > Reviewed-by: Eric Blake <ebl...@redhat.com> >> >> Wait - how did my Reviewed-by get here? There is no [PATCHv2] in the >> subject line to indicate that I reviewed an earlier revision. and the >> only other mail I see from me in the archives with the same subject line >> is here: >> https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg05143.html >> >> where I made a comment, but did NOT give my signature on the patch. >> >> Please follow http://wiki.qemu.org/Contribute/SubmitAPatch when using >> Reviewed-by: tags and subject lines. Otherwise, you are making life >> harder for yourself and for reviewers. >> > I'm so sorry for those, and will post a new version.
>> > +static uint64_t bitmap_sync_cnt; If you change, you can do s/_cnt/_count/? As suggested in the output string? Thanks, Juan. Later, Juan.
