On 5 March 2014 18:14, Richard Henderson <r...@twiddle.net> wrote:
> Fixes a build error when these are different, e.g. x32.
>
> Signed-off-by: Richard Henderson <r...@twiddle.net>
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
A quick grep of the uses of tcg_gen_exit_tb() suggests
we would be better to change this function to take
(TranslationBlock *tb, int tb_exit_code), possibly
also with a special case for 0 if "tcg_gen_exit_tb(NULL, 0)"
seems too verbose.
I'll apply this to target-arm as the fix for 2.0, though.
> ---
> target-arm/translate-a64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
> index 08ac659..37e05e8 100644
> --- a/target-arm/translate-a64.c
> +++ b/target-arm/translate-a64.c
> @@ -210,7 +210,7 @@ static inline void gen_goto_tb(DisasContext *s, int n,
> uint64_t dest)
> if (use_goto_tb(s, n, dest)) {
> tcg_gen_goto_tb(n);
> gen_a64_set_pc_im(dest);
> - tcg_gen_exit_tb((tcg_target_long)tb + n);
> + tcg_gen_exit_tb((intptr_t)tb + n);
> s->is_jmp = DISAS_TB_JUMP;
> } else {
> gen_a64_set_pc_im(dest);
> --
> 1.8.5.3
>
thanks
-- PMM
