From: "Jason J. Herne" <jjhe...@us.ibm.com> This patch is a result of changes requested by Andreas Färber during the S390 cpu hotplug code review.
Andreas, I am unsure if you were asking for the complete removal of the ipi_states array, or the removal of the set/get functions used to encapsulate access to the array, or if you are ok with the current scheme and you just wanted the data accesible within the qom tree as well. The approach I took with this patch was to leave the ipi_states array in place, although it has been renamed for clarity. Because object_property_add_link() expects Object** when pasing the link target, we must have a lasting reference to our S390CPU objects. I'm not sure where we would store these pointers, if not in the currently existing aray. I decided to encapsulate the details in set/get functions instead of (eventually) repeating all of the link related details when we allow the creation of cpus via hotplug. If you are unhappy with how I did this, please assist me in understanding what you would like changed. I am happy to change it as needed. Jason J. Herne (1): s390-cpu: qom interface for S390 cpu states array hw/s390x/s390-virtio.c | 32 +++++++++++++++++++++++--------- target-s390x/cpu.h | 1 + 2 files changed, 24 insertions(+), 9 deletions(-) -- 1.8.3.2
