On 02/28/2014 11:30 AM, Andreas Färber wrote:
Am 26.02.2014 18:18, schrieb Jason J. Herne:
From: "Jason J. Herne" <jjhe...@us.ibm.com>
Modify s390_cpu_addr2state to allow fetching state information for cpu addresses
above smp_cpus. Hotplug requires this capability.
Also add s390_cpu_set_state function to allow modification of ipi_state entries
during hotplug.
Signed-off-by: Jason J. Herne <jjhe...@us.ibm.com>
This patch is *still* present despite your previous response that you
incorporated my review comments. You are adding a custom s390x API here
rather than reusing the generic QOM API as requested. I don't even read
further in such cases - like I pointed out, a pure resend is not helping
address review feedback!
Andreas
Just a quick follow on note. Even though the link property has been
added by this patch set, I just realized this part of the code is not
yet complete. I'll work up a complete patch just to address this issue
and post it separate from Hotplug. I think that makes the most sense
because this is really a qom patch.
--
-- Jason J. Herne (jjhe...@linux.vnet.ibm.com)
