On 03/05/2014 04:11 AM, Alex Bennée wrote: > > Richard Henderson <r...@twiddle.net> writes: > >> Signed-off-by: Richard Henderson <r...@twiddle.net> >> --- >> tcg/aarch64/tcg-target.c | 20 +++++++------------- >> 1 file changed, 7 insertions(+), 13 deletions(-) >> > <snip> >> >> + case INDEX_op_mov_i64: >> + case INDEX_op_mov_i32: >> + case INDEX_op_movi_i64: >> + case INDEX_op_movi_i32: >> + /* Always implemented with tcg_out_mov/i, never with tcg_out_op. */ >> default: >> - tcg_abort(); /* opcode not implemented */ >> + /* Opcode not implemented. */ >> + tcg_abort(); >> } >> } > > Doesn't this fall through and abort for all mov ops? Have I missed > somewhere else that ensures the ops don't come via tcg_out_op? > Yes, the switch statement in tcg_gen_code_common.
r~
