Am 04.03.2014 22:45, schrieb Stefan Hajnoczi: > The path resolution logic in object_property_set_link() should be a > separate function. This makes the code easier to read and maintain. > > More importantly, the error behavior of object_property_set_link() is > dangerous. It sets the link property object to NULL if an error occurs. > A setter function should either succeed or fail, it shouldn't leave the > value NULL on failure. > > This patch splits the code and fixes the error case so the old link > property object is left in place on failure. > > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
Since this code movement is a bit invasive due to the reindent (looks OK though), can we do this in two steps please? First split, then fix? Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
