On 4 March 2014 11:11, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 4 March 2014 02:47, Xuebing Wang <xbi...@gmail.com> wrote: >> include/exec/exec-all.h should ONLY be included in target-xxx/* > > Why? > > This header file defines a number of functions and types > that are used outside target-xxx/. At the moment we implicitly > rely on cpu.h pulling them in.
My question still stands, but this bit is wrong: > Maybe it would be nice to split > out the things that only the target frontends care about from > APIs used by other parts of QEMU, but that's not what this patch > is doing. ...because that is what patch 8 does. Sorry, read those out of order. thanks -- PMM
