Am 27.02.2014 00:51, schrieb Peter Maydell: > The function qobject_from_json() doesn't actually allow its > argument to be a format string -- it passes a NULL va_list* > to qobject_from_jsonv(), and the parser code will then never > actually intepret %-escape sequences (it tests whether the
"interpret" > va_list pointer is NULL and will stop with a parse error). > > The spurious attribute markup causes clang warnings in some > of the test cases where we programmatically construct JSON > to feed to qobject_from_json(): > > tests/test-qmp-input-visitor.c:76:35: warning: format string is not a > string literal (potentially insecure) [-Wformat-security] > data->obj = qobject_from_json(json_string); > ^~~~~~~~~~~ > > Remove the incorrect attribute. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > Suggested-by: Paolo Bonzini <pbonz...@redhat.com> Otherwise Reviewed-by: Andreas Färber <afaer...@suse.de> Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
