On 02/27/2014 04:09 AM, Wenchao Xia wrote: > From: Wenchao Xia <xiaw...@linux.vnet.ibm.com> > > Signed-off-by: Wenchao Xia <xiaw...@linux.vnet.ibm.com> > Signed-off-by: Wenchao Xia <wenchaoq...@gmail.com>
Double S-o-B. The commit message is a bit sparse; the one-line summary mentions what, but for a change like this where you are taking away functionality, it's also good to mention WHY (hint: enum-based discriminators provide better type-safety and ensure that future qapi additions do not forget to adjust dependent unions). > --- > docs/qapi-code-gen.txt | 5 +---- Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
