On 02/27/2014 08:31 AM, Luiz Capitulino wrote: > On Tue, 11 Feb 2014 14:00:14 +0100 > Lluís Vilanova <vilan...@ac.upc.edu> wrote: > >> Adds the "include(...)" primitive to the syntax of QAPI schema files, >> allowing >> these to be modularized into multiple per-topic files in the future. > > Markus, Eric, you commented/reviewed v2 of this series. Any comments > against v3?
A couple nits that still need fixing (see individual messages), but if you feel comfortable fixing them now instead of waiting for a v4, then go ahead and add: Series: Reviewed-by: Eric Blake <ebl...@redhat.com> Then again, adding a cycle test for chained inclusion cycles in test 3 may be best with a v4. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
