On Mon, Feb 17, 2014 at 04:49:43PM +0100, Igor Mammedov wrote: [...] > diff --git a/numa.c b/numa.c > new file mode 100644 > index 0000000..7845036 > --- /dev/null > +++ b/numa.c > @@ -0,0 +1,183 @@ > +/* > + * QEMU System Emulator > + * > + * Copyright (c) 2013 Fujitsu Ltd. > + * Author: Wanlong Gao <gaowanl...@cn.fujitsu.com> > + *
IANAL, but don't you need to keep the copyright assignment from the file from which you are copying the code? There are only 2 lines in this file that were not copied from existing code at vl.c. (The fact that the only copyright notice is (c) 2003-2008 Fabrice Bellard (and -numa was introduced in 2009) may make proper copyright assignment difficult, though.) Copyright questions aside, the code movement looks good, so: Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> > + * Permission is hereby granted, free of charge, to any person obtaining a > copy > + * of this software and associated documentation files (the "Software"), to > deal > + * in the Software without restriction, including without limitation the > rights > + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell > + * copies of the Software, and to permit persons to whom the Software is > + * furnished to do so, subject to the following conditions: > + * > + * The above copyright notice and this permission notice shall be included in > + * all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL > + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > FROM, > + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN > + * THE SOFTWARE. > + */ > + [...] -- Eduardo
