On 21 February 2014 09:41, Alexander Graf <[email protected]> wrote: > We currently size the msi window trap page according to the host's page > size so that we poke a working hole into a memory slot in case we overlap. > > However, this is only ever necessary with KVM active. Without KVM, we should > rather try to be host platform agnostic and use a constant size: 4k. > > This fixes a build breakage on win32 hosts.
Unfortunately it doesn't: cam-vm-266:precise:qemu$ make -C build/w32 make: Entering directory `/home/petmay01/linaro/qemu-from-laptop/qemu/build/w32' CC ppc64-softmmu/hw/ppc/spapr_pci.o cc1: warnings being treated as errors /home/petmay01/linaro/qemu-from-laptop/qemu/hw/ppc/spapr_pci.c: In function ‘spapr_pci_msi_init’: /home/petmay01/linaro/qemu-from-laptop/qemu/hw/ppc/spapr_pci.c:486: warning: implicit declaration of function ‘getpagesize’ /home/petmay01/linaro/qemu-from-laptop/qemu/hw/ppc/spapr_pci.c:486: warning: nested extern declaration of ‘getpagesize’ The compiler complains that there's no declaration of the function you're trying to call before it gets around to deciding whether it can eliminate the code as unreachable. thanks -- PMM
