Am 18.02.2014 13:38, schrieb Greg Kurz:
> On Fri, 14 Feb 2014 12:59:49 +0100
> Andreas Färber <afaer...@suse.de> wrote:
>
>> Hi,
>>
>> [...]
>>
>> It might've helped if Rusty had actually used our
>> scripts/get_maintainer.pl script to CC people. While Anthony seems to
>> have reviewed some patches (usually Reviewed-by should be before the
>> final Signed-off-by fwiw), neither Stefan (virtio-net) nor Kevin
>> (virtio-blk) nor Paolo (virtio-scsi) were CC'ed, and recently Michael
>> stepped up as virtio maintainer, so maybe he can take them once ready.
>>
>> 1/7 looks okay to me; 3-7 are rather mechanical - people will need to
>> review that those changes are sufficient for the current code base.
>> We've since converted virtio devices to QOM realize, so a rebase is
>> likely needed for such an "old" series.
Hi,
> Thank you Andreas for your support. :)
>
> Here is a rebased patchset. Only the two first patches ("virtio_get_byteswap:"
> and "virtio:") had to be updated actually. FWIW, this the very same patchset
> I use, along with some ppc64 specific enablement code, to have functionnal
> ppc64 LE guests.
Some more support: ;) When you resend with Connie's fix, please send as
top-level patchset, and labeled "PATCH v5" (or whatever the count ... I
counted the one you replied to as v3). Please also don't forget to sign
off all patches you send out, even if unchanged. Your [ ... ] comments
should go right before your Sob (unless Rusty did sign them off).
>
> ---
>
> Greg Kurz (1):
> hw/9pfs/virtio_9p_device: use virtio wrappers to access headers.
"virtio-9p-device" (or just "virtio-9p")
>
> Rusty Russell (7):
> virtio_get_byteswap: function for endian-ambivalent targets using
> virtio.
> virtio: allow byte swapping for vring and config access
> hw/net/virtio-net: use virtio wrappers to access headers.
> hw/net/virtio-balloon: use virtio wrappers to access page frame numbers.
> hw/block/virtio-blk: use virtio wrappers to access headers.
> hw/scsi/virtio-scsi: use virtio wrappers to access headers.
> hw/char/virtio-serial-bus: use virtio wrappers to access headers.
While at it, some things you've copied...
Usually subjects don't end in a full stop, similar to English headings.
Opinions are divided on whether they should start with a capital letter.
Generally, hw/foo/virtio-bar is redundant and could be just virtio-bar.
http://git.qemu.org/?p=qemu.git&a=search&h=HEAD&st=commit&s=virtio
But it's not wrong and terribly important either. :)
Regards,
Andreas
>
>
> hw/9pfs/virtio-9p-device.c | 3 +
> hw/block/virtio-blk.c | 35 +++++-----
> hw/char/virtio-serial-bus.c | 34 +++++-----
> hw/net/virtio-net.c | 15 ++--
> hw/scsi/virtio-scsi.c | 33 +++++----
> hw/virtio/virtio-balloon.c | 3 +
> hw/virtio/virtio.c | 38 ++++++-----
> include/hw/virtio/virtio-access.h | 132
> +++++++++++++++++++++++++++++++++++++
> include/hw/virtio/virtio.h | 2 +
> stubs/Makefile.objs | 1
> stubs/virtio_get_byteswap.c | 6 ++
> 11 files changed, 228 insertions(+), 74 deletions(-)
> create mode 100644 include/hw/virtio/virtio-access.h
> create mode 100644 stubs/virtio_get_byteswap.c
>
> Best Regards.
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
