________________________________________ From: Andreas Färber [afaer...@suse.de] Sent: Thursday, February 13, 2014 5:11 PM To: Peter Maydell; Petar Jovanovic Cc: QEMU Developers; Petar Jovanovic; Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH v2 1/4] target-mips: add CPU definition for MIPS32R5
> No objection from my side. I was however expecting Petar to drop the > FIXME in response to my reply, which I believe was still in the PULL. > Peter, are you planning (or did I miss) a follow-up cleaning that up, > whether for your new model or for all? I would leave this FIXME, since we need to fix at least .CP0_PRid value once the real silicon is available, because it will have to match value known to kernel at that time. As for other FIXMEs in the same file, I would change that in a separate patch later. I do plan to update this area more, with additional 5KEc and 5KEf models. Regards, Petar