2014/1/26 Andreas Färber <afaer...@suse.de> > Am 18.01.2014 12:54, schrieb Kewei Yu: > > > > 2014/1/17 Andreas Färber <afaer...@suse.de <mailto:afaer...@suse.de>> > > > > Am 15.01.2014 11:22, schrieb Kevin Wolf: > > > From: Kewei Yu <kewe...@gmail.com <mailto:kewe...@gmail.com>> > > > > > > When we disable vnc from "./configure", QEMU can't use the vnc > option. > > > So qtest can't use the "vnc -none ", otherwise "make check" fails. > > > If QEMU uses "-display none", "-vnc none" is excrescent, So we > > just need to drop it. > > > > > > Signed-off-by: Kewei Yu <kewe...@gmail.com <mailto: > kewe...@gmail.com>> > > > Reviewed-by: Paolo Bonzini <pbonz...@redhat.com > > <mailto:pbonz...@redhat.com>> > > > Signed-off-by: Kevin Wolf <kw...@redhat.com <mailto: > kw...@redhat.com>> > > > > If the pull does get respun, 'Fix "make check" failing for > > --disable-vnc' would be better English. ;) > > > > Yes, It is more accurate. So.... I should re-submit it? > > Sorry for the late answer. Since it was already in the maintainer's > queue and just about the commit message, it's not necessary for you to > resubmit, my comment was addressed to Kevin. When a "PULL" has been > sent, only major reasons (like build breakages, missing/wrong Sob, etc.) > lead to a resubmission by the maintainer. > > Apart from the grammar issues ("causes ... to fail" or "... failure", > "disabling ... causes"), please keep in mind that many commits fix bugs, > so it will be more useful to the reader of patch/commit to read > prominently what is changing (and why) to determine whether he/she is > affected. Hope that explains. > Thank you for your patient explains, I will. ^ ^
Regards, Kewei > > Regards, > Andreas > > > > > > > Andreas > > > > -- > > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG > Nürnberg > > > > Kewei > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg >
