On 24.01.2014 14:26, Kevin Wolf wrote:
Am 23.01.2014 um 21:31 hat Benoît Canet geschrieben:
Signed-off-by: Benoit Canet <ben...@irqsave.net>
---
block.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
I'm not going to merge this one yet. It breaks qemu-iotests case 071,
which would have to be adapted.
However, first of all I'd like to hear the opinions of at least Eric and
Max on what BlockRef should really refer to. I think node names make
most sense, but perhaps it's a bit inconvenient and the command line
should default to node-name = id when id is set, but node-name isn't?
The QAPI schema is pretty clear about this: “references the ID of an
existing block device.” However, if the ID cannot be found, I think we
should interpret it as a reference to the node name.
Therefore, I'd first try bdrv_find() and if that returns NULL, try again
with bdrv_find_node().
Max
