Le Tuesday 21 Jan 2014 à 16:44:49 (+0100), Kevin Wolf a écrit :
> Am 21.01.2014 um 16:36 hat Benoît Canet geschrieben:
> > Le Tuesday 21 Jan 2014 à 15:33:09 (+0100), Kevin Wolf a écrit :
> > > Am 12.12.2013 um 16:33 hat Benoît Canet geschrieben:
> > > > v5:
> > > > block empty node names [Kevin]
> > > > factorize setting of node-name option [Kevin]
> > > > NULL terminate node_name on removal [Kevin]
> > > > make query-named-block-nodes return BlockDeviceInfo structure [Eric]
> > > > Change some doc in query-named-block-nodes [Eric]
> > > > Document the choice of the QMP API for node name [Eric]
> > > > Use the same authorization as snapshot on block resize [Kevin]
> > > > Rebase the series [Kevin]
> > > >
> > > > Benoît Canet (7):
> > > > block: Add bs->node_name to hold the name of a bs node of the bs
> > > > graph.
> > > > block: Allow the user to define "node-name" option.
> > > > qmp: Add a command to list the named BlockDriverState nodes.
> > > > qmp: Allow to change password on named block driver states.
> > > > block: Create authorizations mechanism for external snapshot and
> > > > resize.
> > > > qmp: Allow block_resize to manipulate bs graph nodes.
> > > > qmp: Allow to take external snapshots on bs graphs node.
> > >
> > > One more general question: Now that we have node names, should
> > > bdrv_file_open() use node names rather than device names for references?
> > > (Well, no, come to think of it, it's not really a question, but more of
> > > a request ;-))
> > :)
> > I don't understand what you mean: I don't see any reference to device_name
> > in
> > bdrv_file_open only one in bdrv_open which is used in a printf.
>
> I'm talking about the function parameter 'const char *reference', which
> references an existing block device rather than opening a new one. It
> doesn't directly use device_name, but it calls bdrv_find().
>
> Kevin
>
Do you mean this one:
{ 'union': 'BlockdevRef',
'discriminator': {},
'data': { 'definition': 'BlockdevOptions',
'reference': 'str' } }
I though that QMP names where set in stone.
Best regards
Benoît
