On 7 January 2014 04:35, Alexey Kardashevskiy <a...@ozlabs.ru> wrote: > One of our users tried an X86 image with qemu-system-ppc64. Instead of > printing some reasonable message (which is possible in this case as the image > is ELF), QEMU (spapr.c) simply copied the image in RAM as a raw image and > SLOF failed to boot from it. > > The patch fixes the issue but there are still questions. > > 1. Do we need more sophisticated error checking here? Return -2 instead of > exit(1) > and do exit(1) few levels up?
I definitely don't think we should be doing printf-and-exit at this level; we should report something helpful to the next level up. -kernel is a mess anyway, the behaviour differs across architectures regarding what is and isn't supported. thanks -- PMM
