On 23 December 2013 14:24, Michael S. Tsirkin <m...@redhat.com> wrote:
> Changes from v1:
> added a TODO so we remember why the extra line is here.
>
> target-arm/cpu64.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/target-arm/cpu64.c b/target-arm/cpu64.c
> index 04ce879..a9d6939 100644
> --- a/target-arm/cpu64.c
> +++ b/target-arm/cpu64.c
> @@ -58,6 +58,7 @@ static const ARMCPUInfo aarch64_cpus[] = {
> #ifdef CONFIG_USER_ONLY
> { .name = "any", .initfn = aarch64_any_initfn },
> #endif
> + { .name = NULL } /* TODO: drop when we support more CPUs */
> };
>
> static void aarch64_cpu_initfn(Object *obj)
> @@ -100,6 +101,10 @@ static void aarch64_cpu_register(const ARMCPUInfo *info)
> .class_init = info->class_init,
> };
>
> + if (!info->name) {
> + return;
> + }
I said TODOs in both places, please, especially since this
is the one most likely to be overlooked.
thanks
-- PMM
