On 22 December 2013 19:01, Stefan Weil <s...@weilnetz.de> wrote:
>
> v2: Address Peter Maydell's suggestions:
> * Use first alternative, so there is no change of behaviour
No, I said that the compiler picked the last of the two, (5,3)
> [0x39] = {5,2}, /* space */
> - [0x39] = {5,3}, /* space */
> - [0x1c] = {5,5}, /* enter */
> + /*
> + * There are two matrix positions which map to space,
> + * but QEMU can only use one of them for the reverse
> + * mapping, so simply use the first one.
> + */
> + /* [0x39] = {5,3}, space */
So this is still wrong.
> + /*
> + * Matrix position {5,4} and other keys are missing here.
> + * TODO: Compare with Linux code and test real hardware.
> + */
> + [0x1c] = {5,5}, /* enter (TODO: might be wrong) */
> [0xc8] = {6,0}, /* up */
> [0xd0] = {6,1}, /* down */
> [0xcb] = {6,2}, /* left */
thanks
-- PMM
