Re: [Qemu-devel] [PATCH 01/21] target-arm: A64: add support for ld/st pair

[Richard Henderson]

On 12/17/2013 07:12 AM, Peter Maydell wrote:
> +    TCGMemOp memop =  MO_TE + size;

Watch the double space (multiple occurrences).


> +    if (is_vector) {
> +        if (opc == 3) {
> +            unallocated_encoding(s);
> +            return;
> +        }

In the integer LDP description I see

  if L:opc<0> == '01' || opc == '11' then UnallocatedEncoding();

I think that opc == 3 check should be hoisted outside is_vector.


r~