On Wed, 18 Dec 2013, Andreas Färber wrote: > Am 18.12.2013 20:20, schrieb Stefano Stabellini: > > On Wed, 18 Dec 2013, Andreas Färber wrote: > >> Am 18.12.2013 18:57, schrieb Andreas Färber: > >>> Am 05.11.2013 11:16, schrieb xiaoqiang zhao: > >>>> xiaoqiang zhao (4): > >>>> apic: Cleanup for QOM'ify > >>>> apic: QOM'ify apic & icc_bus > >>>> ioapic: Cleanup for QOM'ify > >>>> ioapic: QOM'ify ioapic > >>> > >>> Thanks, I have rebased and queued them with changes on qom-next: > >>> https://github.com/afaerber/qemu-cpu/commits/qom-next > >>> > >>> In particular I have reverted TYPE_ introductions were unnecessary and > >>> reverted usages of TYPE_ constants for MemoryRegions. Also two white > >>> lines have been dropped. The ICC bus conversion has been split out as a > >>> separate step, using NULL errp as intermediate step since ignored. > >>> (CC'ing Peter C. and Luiz) > >> > >> Oh and you forgot to convert the Xen APIC, I trivially fixed that. > >> (CC'ing Stefano) > > > > Yes, it should be really trivial. Give a look at hw/xen/xen_apic.c. > > https://github.com/afaerber/qemu-cpu/commit/40ae2368c4c9135971c69fa680949b5b1cfa4410#diff-3 > > Just wanted to give you a heads-up that we're messing in your code. :)
Ah OK, thank you :-)