On 12/09/2013 07:47 AM, Tom Musta wrote: > -static void gen_conditional_store (DisasContext *ctx, TCGv EA, > +static void gen_conditional_store(DisasContext *ctx, TCGv EA, > int reg, int size)
If you're going to make random changes to the formatting, fix it all -- the indentation on the next line is now wrong. > + gen_qemu_##storeop(ctx, cpu_gpr[rS(ctx->opcode)], t0); \ I meant to mention this for l*arx too, but please use the new ldst opcodes. That'll save me having to make the change here in the next couple of weeks. Also, surely better to implement gen_conditional_store !USER, instead of duplicating the STCX macro. r~
