On Thu, Dec 10, 2009 at 09:56:06AM -0200, Luiz Capitulino wrote: > On Thu, 10 Dec 2009 11:34:37 +0100 > Markus Armbruster <arm...@redhat.com> wrote: > > > > +/** > > > + * do_info_vnc(): Show VNC server information > > > + * > > > + * Return a QDict with server information. Connected clients are returned > > > + * as a QList of QDicts. > > > + * > > > + * The main QDict contains the following: > > > + * > > > + * - "status": "disabled" or "enabled" > > > + * - "host": server's IP address > > > + * - "service": server's port number > > > + * - "auth": authentication method (optional) > > > + * - "clients": a QList of all connected clients > > > + * > > > + * Clients are described by a QDict, with the following information: > > > + * > > > + * - "host": client's IP address > > > + * - "service": client's port number > > > + * - "x509 dname": TLS dname (optional) > > > > Sure you want dict keys with spaces? I'd prefer "x509-dname". > > I don't think it's a big deal because this string will never > change, but would be good to come with a standard style for > dict keys (at least for the protocol).
I agree with Markus, that it is nicer to avoid spaces in the dict keys, even if technically it is allowed. I'd vote for x509-dname too. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
