Luiz Capitulino <lcapitul...@redhat.com> writes:
> While there update the documentation as well.
>
> Signed-off-by: Luiz Capitulino <lcapitul...@redhat.com>
> ---
> monitor.c | 39 ++++++++++++++++++++++++++-------------
> 1 files changed, 26 insertions(+), 13 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index aa56ec7..8729535 100644
> --- a/monitor.c
> +++ b/monitor.c
[...]
> @@ -650,12 +652,22 @@ static void monitor_print_cpus(Monitor *mon, const
> QObject *data)
> /**
> * do_info_cpus(): Show CPU information
> *
> - * Return a QList with a QDict for each CPU.
> + * Return a QList. Each CPU is represented by a QDict, which contains:
> *
> - * For example:
> + * - "cpu": CPU index
> + * - "current": true if this is the current CPU, false otherwise
> + * - "halted": true if the cpu is halted, false otherwise
> + * - Current program counter, in decimal. The key name depends on
Do we want to specify the base for numbers in the JSON?
If yes, why not use decimal everywhere?
Aside, if we use hexadecimal in JSON at all, then I'd prefer addresses
to be hexadecimal.
> + * the architecture:
> + * "pc": i386/x86)64
> + * "nip": PPC
> + * "pc" and "npc": sparc
> + * "PC": mips
> *
> - * [ { "CPU": 0, "current": "yes", "pc": 0x..., "halted": "no" },
> - * { "CPU": 1, "current": "no", "pc": 0x..., "halted": "yes" } ]
> + * Example:
> + *
> + * [ { "CPU": 0, "current": true, "halted": false, "pc": 3227107138 },
> + * { "CPU": 1, "current": false, "halted": true, "pc": 7108165 } ]
> */
> static void do_info_cpus(Monitor *mon, QObject **ret_data)
[...]
