On Wed, Dec 04, 2013 at 02:16:28PM -0500, Jeff Cody wrote: > On Fri, Nov 22, 2013 at 12:46:17PM +0530, Bharata B Rao wrote: > > + > > + ret = glfs_zerofill_async(s->fd, offset, size, &gluster_finish_aiocb, > > acb); > > + if (ret < 0) { > > I believe glfs_zerofill_async returns -1 on failure, and sets errno. > In that case, we should set ret = -errno here.
This needs to be done for other routines too. Will address this and the other comment you have given in 2/3 thread. Thanks. Regards, Bharata.