On Wed, Nov 20, 2013 at 03:44:16PM +0800, Fam Zheng wrote: > The "raw" doesn't always work on certain file systems (e.g. tmpfs). Use > qcow2 to make the allocation status explicit. > > Signed-off-by: Fam Zheng <f...@redhat.com> > --- > tests/qemu-iotests/048 | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/048 b/tests/qemu-iotests/048 > index 9def7fc..0fb5d2c 100755 > --- a/tests/qemu-iotests/048 > +++ b/tests/qemu-iotests/048 > @@ -88,7 +88,13 @@ event = "read_aio" > errno = "5" > once ="off" > EOF > -_make_test_img $size > +if [ "$IMGFMT" = "raw" ]; then > + # For raw the allocation status for new image depends on file system, > force > + # qcow2 in this case, since the tested code is in block layer > + IMGFMT=qcow2 _make_test_img $size | _filter_imgfmt
If it can't be tested, skip the test. Don't silently test something else. Stefan
