On 15 November 2013 10:54, Paolo Bonzini <pbonz...@redhat.com> wrote: > It's okay. There are indeed advantages to putting this together with > the definitions, instead of splitting it between target-arm/cpu.h and > target-arm/kvm.c.
Cool. I just wanted to check I wasn't missing some clever approach to this that might have avoided the need to duplicate all the definitions. > The patch is missing the removal of the check from kvm.c though. Yeah, I put this out in a bit of a hurry last thing in the evening. You'll notice I forgot the copyright/license boilerplate in the header comment too. thanks -- PMM
