Il 14/11/2013 12:06, Peter Maydell ha scritto: > On 14 November 2013 05:40, Stefan Weil <s...@weilnetz.de> wrote: >> If you happen to write a v3 patch, g_assert_not_reached would be even >> better than abort. >> >> It's impossible to tell why QEMU terminated after an assert without a >> debugger, >> whereas g_assert_not_reached clearly shows the location. > > Maybe. I was mostly just following the pattern of existing > stub functions. Should all instances of abort() be replaced? > (g_assert_not_reached() is compile-time disablable, unlike > abort()).
No, disabling asserts is almost always bad, but disabling unconditional asserts is even worse. Paolo
