Il 06/11/2013 13:22, Igor Mammedov ha scritto: >>> > > 'gb_align' is one shot usage, it would be better to just add it as an >>> > > argument >>> > > to pc_memory_init(). That would allow to avoid extending PcGuestInfo >>> > > needlessly, >>> > > since gb_align isn't reused. >> > >> > No, Marcelo's way is better. pc_memory_init already has too many >> > arguments, moving them to PcGuestInfo (which ultimately might become >> > properties of the /machine QOM object) is the right thing to do. > In general I agree. But unless there is plans to reuse gb_align in future,
The plan is to turn it (and also has_acpi_build etc.) into a global property that can be set using the usual compat-property machinery. > it doesn't really belong to PcGuestInfo (this change however looks like > cannibalizing structure for argument passing only). For now, it doesn't just look like that, it is like that. :) But it is still a step in the right direction. Paolo
