On 12/05/2009 12:30 AM, Anthony Liguori wrote:
Paul Brook wrote:
On Monday 30 November 2009, Alexander Graf wrote:
Currently we have this stupid role of disallowing:
if (r)
break;
This has been discussed to death several times, in several different
paces, and with no clear resolution or consensus, so I'm going to
make an executive decision:
The coding style stays as-is. Braces are required. Please ensure that
all patches follow the coding style. There may be exceptions, but
there should be a *good* reason for deviation.
If there are real problems or ambiguities in the coding style then I
am willing to consider fixing it. This particular change meets
neither criteria.
By picking a single coding style we've pretty much guaranteed that
most people will disagree with some of it. IMO consistency is more
important.
I agree 100%.
+1'ed, and I note that although brace-happy code looks more cluttered it
is a bit safer and produces cleaner patches.
--
Do not meddle in the internals of kernels, for they are subtle and quick to
panic.
