________________________________________ From: Alex Bennée [alex.ben...@linaro.org] Sent: Monday, November 04, 2013 5:46 PM To: Petar Jovanovic Cc: qemu-devel@nongnu.org; peter.mayd...@linaro.org; riku.voi...@linaro.org; Petar Jovanovic; aurel...@aurel32.net; afaer...@suse.de Subject: Re: [Qemu-devel] [PATCH v3 1/2] linux-user: create target_structsheader to place ipc_perm and shmid_dss
> There is an awful lot of similarity between a lot of the structures > while not being totally identical. Given the syscall munging is common > is there not an argument for having a common header for this case? Hi Alex, I am not sure I understand your point. This used to be all in one file, now it is divided in arch-specific files that can be later populated with other target specific struct definitions. This was also suggested in the first review a month ago. Regards, Petar