12.10.2013 00:44, Petar Jovanovic wrote:
________________________________________
From: Peter Maydell [peter.mayd...@linaro.org]
Sent: Friday, October 11, 2013 9:10 PM
To: Petar Jovanovic
Cc: QEMU Developers; QEMU Trivial; Riku Voipio; Petar Jovanovic; Aurelien Jarno
Subject: Re: [Qemu-devel] [PATCH] linux-user: pass correct parameter to
do_shmctl()
On 11 October 2013 22:03, Petar Jovanovic <petar.jovano...@rt-rk.com> wrote:
From: Petar Jovanovic <petar.jovano...@imgtec.com>
Fix shmctl issue by passing correct parameter buf to do_shmctl().
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
It would be nice if you gave more detail than "shmctl issue"...
Yes, indeed. However, this is a bit tricky, because it can be associated
with different issues, and this particular fix is a follow up to an
another change [1] that I posted previously that defines arch-specific
structs target_ipc_perm and target_shmid_ds. The layout of the structs
is important.
What "[1]" are you referring to?
This particular change will for instance, when joined with the
preceding change, make the code correctly return values in the buf
struct after:
shmctl(shm_id, IPC_STAT, &buf)
Different architectures benefit from these two patches.
Shouldn't the two patches be applied together and be routed via some
other, "non-trivial" tree instead?
Thanks,
/mjt
