On 7 September 2013 08:04, Antony Pavlov <antonynpav...@gmail.com> wrote: > + > +static void digic4_board_init(DigicBoard *board) > +{ > + Error *err = NULL; > + > + DigicBoardState *s = g_new(DigicBoardState, 1); > + > + s->digic = DIGIC(object_new(TYPE_DIGIC)); > + object_property_set_bool(OBJECT(s->digic), true, "realized", &err); > + if (err != NULL) { > + fprintf(stderr, "Couldn't realize DIGIC SoC: %s\n", > + error_get_pretty(err)); > + exit(1); > + } > + > + digic4_board_setup_ram(s, board->ram_size); > + > + s->digic->cpu.env.regs[15] = board->start_addr;
I still think this is wrong. Real hardware can't possibly start at this address; we should boot the same way the hardware does. > +} > + > +static DigicBoard digic4_board_canon_a1100 = { > + .ram_size = 64 * 1024 * 1024, > + /* CHDK recommends this address for ROM disassembly */ > + .start_addr = 0xffc00000, > +}; thanks -- PMM