On Thu, Oct 17, 2013 at 12:25:32AM +0200, Paolo Bonzini wrote: > >> qtest could at best host some sanity checks on the ACPI tables, which > >> would catch the MCFG problems that Gerd reported on v5. > > > > Depends on how deep the test understands ACPI - the signature > > was wrong I think. > > > > Note I was testing this too - comparing tables between > > revisions. I just didn't notice that list of tables > > to test included was generated by me on piix, so > > MCFG wasn't tested. > > So we could have a qtest for sanity checking ACPI tables. At least > fw_cfg is one of the few components that has qtest infrastructure... I > don't think we need to do more than that though. The set of sanity > checks can start with a simple list of tables that "have to be there" > for a given machine type. > > Paolo
Well this means these tests won't pass on old qemu so they would be useless for comparing old to new. And in this case, while it's a good idea to have them I don't see why it's a blocker for merging. -- MST
