On 15 October 2013 15:25, Alex Bennée <alex.ben...@linaro.org> wrote: > peter.mayd...@linaro.org writes: >> This sounds like the code was written based on the kernel, not >> on the board docs, which is wrong, so I think it could use >> rephrasing. There's no need to mention previous behaviour either >> IMHO -- people who care can look at the commit history. > > Sure. I've got a bunch of other review comments to address so I can > clean this up. Unfortunately I've been so busy with other stuff I > haven't had a chance to go through them yet. > > As it happens it looks like the integrator image is now running again on > the current HEAD which has made this a little less urgent. However it > does raise an interesting question as to why!
Commits 3bb28b72 and 68a7439a1 reverted the changes to the behaviour of reads from unassigned regions (since they were causing widespread brokenness). >>> + * Written by Alex Bennée >> >> Assuming you wrote this with your Linaro hat on, the comment >> should have a >> * Copyright (c) 2013 Linaro Limited >> >> in it above your 'Written by' line. > > Yeah, I was holding off that until I was officially on the clock > although as noticed I have been taking advantage of the email facilities > as a handy place to have the mailing list go through. Well, it needs *some* copyright line, at least, for whichever entity has the rights to the code and ability to (re)license it... thanks -- PMM
