Hi, Am 14.10.2013 18:29, schrieb Michael Walle: > This allows us to completely remove CPULM32State from DisasContext. > Instead, copy the fields we need to DisasContext. > > Cc: Andreas Färber <afaer...@suse.de> > Signed-off-by: Michael Walle <mich...@walle.cc>
Sorry for not getting to review this earlier. The subject makes it sound to me as if a "features" field were being moved from CPULM32State to LM32CPU, which would be great, as done or proposed elsewhere. However, instead it is adding a pointer field to LM32CPU to the definition the class was originally created from IIUC. I would rather access those fields through LM32CPUClass then (an existing pointer in the object instance) - but since xtensa is still doing the same and this not being functionally wrong, no objection to the pull, just a note that we should revisit it. Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
