On 10/09/2013 01:10 PM, Eric Blake wrote: > On 10/09/2013 05:28 AM, Juan Quintela wrote: >> We don't need to make special things for CODE, just set the other two bits >> >> Signed-off-by: Juan Quintela <quint...@redhat.com> >> --- >> exec.c | 8 ++------ >> 1 file changed, 2 insertions(+), 6 deletions(-) >> > >> - dirty_flags |= (0xff & ~CODE_DIRTY_FLAG); >> - cpu_physical_memory_set_dirty_flags(ram_addr, dirty_flags); >> + cpu_physical_memory_set_dirty_flag(ram_addr, MIGRATION_DIRTY_FLAG); >> + cpu_physical_memory_set_dirty_flag(ram_addr, VGA_DIRTY_FLAG); > > Worth writing as a single call: > > cpu_physical_memory_set_dirty_flag(ram_addr, > MIGRATION_DIRTY_FLAG|VGA_DIRTY_FLAG); > > or will that just get in the way of refactoring later in the series?
Answering myself - it gets in the way. Doing things explicitly one flag at a time makes it easier to redirect flags to separate tables. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
