On 10/07/2013 01:45 PM, Peter Maydell wrote: > On 7 October 2013 19:11, Fabien Chouteau <chout...@adacore.com> wrote: >> On 10/04/2013 07:49 PM, Peter Maydell wrote: >>> On 5 October 2013 01:57, Fabien Chouteau <chout...@adacore.com> wrote: >>>>> @@ -47,7 +48,9 @@ >>>> #include "hw/xen/xen.h" >>>> #include "hw/i386/apic_internal.h" >>>> #endif >>>> +#include "monitor/monitor_def.h" >>>> >>>> +extern const MonitorDef i386_monitor_defs[]; >>> >>> Declare this in cpu-qom.h, rather than having an >>> extern declaration in a .c file. >>> >> >> I didn't manage to do that. > > If you just say "I couldn't make that work" with no details, > there isn't much I can say beyond "try harder" :-) > If you say *why* you couldn't get it to work then I'm more > likely to either (a) suggest an approach that will work or > (b) accept that it really does have to be that way... >
Sorry I sent the email too quickly. It looks like a circular dependency In file included from /home/chouteau/src/qemu-main/target-arm/cpu.h:294:0, from /home/chouteau/src/qemu-main/include/monitor/monitor_def.h:4, from /home/chouteau/src/qemu-main/target-arm/monitor.c:20: /home/chouteau/src/qemu-main/target-arm/cpu-qom.h:184:25: error: array type has incomplete element type make[1]: *** [target-arm/monitor.o] Error 1 monitor_def.h -> cpu.h -> cpu-qom.h -. ^ | |__________________________________/ -- Fabien Chouteau