On 10/01/2013 03:09 PM, Tomoki Sekiyama wrote: > Currently, fsfreeze-freeze may cause deadlock if a guest has loopback mounts > of image files in its disk; e.g.: > > # mount | grep ^/ > /dev/vda1 / type ext4 (rw,noatime,seclabel,data=ordered) > /tmp/disk.img on /mnt type ext4 (rw,relatime,seclabel) > > To avoid the deadlock, this freeze filesystems in reverse order of mounts.
s/freeze/freezes/ > > Signed-off-by: Tomoki Sekiyama <tomoki.sekiy...@hds.com> > --- > qga/commands-posix.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thaw already worked in the forward direction; with your patch, this means thaw undoes the actions by freeze in the opposite order (last frozen is first thawed), which is also a good thing. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
