On 09/08/2013 08:57 PM, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia <xiaw...@linux.vnet.ibm.com> > --- > block/qcow2-snapshot.c | 20 ++++++++++++++++---- > 1 files changed, 16 insertions(+), 4 deletions(-) >
>
> +restore_refcount:
> + if (qcow2_update_snapshot_refcount(bs, s->l1_table_offset, s->l1_size,
> -1)
> + < 0) {
> + /* Nothing can be done none now, need image check later */
s/none //
> + error_report("qcow2: Error in restoring refcount in snapshot");
> + }
Do we need to (attempt to) mark image metadata to mark the image
corrupted at this point? Is it still wise to try and fall through to
freeing the clusters?
> +
> +dealloc_cluster:
> + qcow2_free_clusters(bs, sn->l1_table_offset,
> + sn->l1_size * sizeof(uint64_t),
> + QCOW2_DISCARD_ALWAYS);
> +
> fail:
> g_free(sn->id_str);
> g_free(sn->name);
>
On the surface, this makes sense, but I'd rather defer the technical
review to someone more familiar with qcow2 code.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
