On 09/23/2013 06:09 AM, Max Reitz wrote: > Add a test for the additional information now provided by qemu-img info > when used on qcow2 images. > > Signed-off-by: Max Reitz <mre...@redhat.com> > --- > tests/qemu-iotests/065 | 72 > ++++++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/065.out | 22 ++++++++++++++ > tests/qemu-iotests/group | 1 + > 3 files changed, 95 insertions(+) > create mode 100755 tests/qemu-iotests/065 > create mode 100644 tests/qemu-iotests/065.out
This patch only tests human output, not JSON. > +# creator > +owner=mre...@redhat.com > + > +seq=`basename $0` > +echo "QA output created by $seq" > + > +here=`pwd` Not your fault (copy-and-paste from other tests), but as long as we are requiring bash, $PWD is much faster than `pwd`, and $() is nicer than `` where we don't have even faster shortcuts like $PWD. > +=== Testing qcow2 image with -o compat=0.10 === > + > +Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864 > +Format specific information: > +compat: 0.10 Should we be indenting the human output, to make it obvious how many remaining fields are being output as a result of format specific information? I'm still not happy with 5/6 in its current form, but can live with this patch as-is if we don't bother with testing JSON form. Does 5/6 even need to worry about stripping JSON form, if you aren't going to test JSON form? Depending on the answer to that question: Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
