Kevin Wolf <kw...@redhat.com> writes:

> Currently qcow2 unnecessarily rounds up the length of the backing format 
> string
> to the next multiple of 8. At the same time, the array in BlockDriverState can
> only hold 15 characters, so in effect backing formats with 9 characters or 
> more
> don't work (e.g. host_device).
>
> Save the real string length and things start to work for all valid image 
> format
> names.
>
> Signed-off-by: Kevin Wolf <kw...@redhat.com>

Looks good to me.

> ---
>
> v2:
> - Don't rely on sizeof(ext) being a multiple of 8

Broken before your patch, so this is bonus fix.


Reply via email to