On 18 September 2013 17:08, Alexey Kardashevskiy <a...@ozlabs.ru> wrote: > On 09/18/2013 05:59 PM, Peter Maydell wrote: > It would be awesome if you just gave me any really good example of what you > expect from such a comment as kvm-all.c does not have any whatsoever. And > pci.c does not. And exec.c does not. But I am sure there is some as > it cannot possibly be me who starts making such comments in qemu. Thanks.
Yes, we have a lot of preexisting undocumented functions. It's very common in QEMU for existing code not to be up to preferred standards; you can't use current code as a yardstick for "good enough to pass code review". The example I usually crib from for formatting is the extract/deposit APIs in include/qemu/bitops.h. include/exec/memory.h is also well documented. -- PMM
