On 16.09.2013 17:07, Richard Henderson wrote: > On 09/16/2013 12:45 AM, Claudio Fontana wrote: >>>> default: >>>> - tcg_abort(); /* opcode not implemented */ >>>> + /* Opcode not implemented. */ >>>> + tcg_abort(); >>>> } >>>> } >> This change above seems unnecessary. > > Perhaps qemu doesn't have the same "comments are sentences" rule that gcc > does, > but I still aim to follow it. >
It is wasteful of y space for no reason. This comment is not a sentence, when you read the code as you would prose. It is a comment _on_ tcg_abort() : tcg_abort(), because the opcode is not implemented. In other cases, the comment alone on a line is a good idea, but not in this one. C.
