On Sun, Sep 15, 2013 at 06:29:51PM +0100, Peter Maydell wrote: > On 15 September 2013 18:07, Michael S. Tsirkin <m...@redhat.com> wrote: > > On Sun, Sep 15, 2013 at 05:55:54PM +0100, Peter Maydell wrote: > >> On 15 September 2013 16:24, Michael S. Tsirkin <m...@redhat.com> wrote: > >> > On Sun, Sep 15, 2013 at 03:51:53PM +0100, Peter Maydell wrote: > >> >> The memory core uses the following rules to select a memory region > >> >> when the > >> >> @@ -93,8 +136,11 @@ guest accesses an address: > >> >> - if the subregion is a leaf (RAM or MMIO), the search terminates > >> > > >> > Maybe add > >> > "And the leaf is selected" > >> > >> Not sure what you mean by "selected" here. > > > > Well search terminates but what is the result? > > It says "to select a memory region" > > so for the result I said "is selected". > > Oh, I see. I thought you were suggesting "if the subregion is a leaf > and the leaf is selected, the search terminates"... > > My suggested text below uses the phrasing "the search terminates > with X", so perhaps "the search terminates with this leaf region" ? > Better, make both of them be "the search terminates, returning X". > > -- PMM
Sounds good.
