On 09/13/2013 04:25 AM, Peter Lieven wrote:
> if the call is invoked through bdrv_is_allocated the caller might
> expect *pnum = 0 on error. however, a new implementation of
> bdrv_get_block_status might only return a negative exit value on
> error while keeping *pnum untouched.
> 
> Signed-off-by: Peter Lieven <p...@kamp.de>
> ---
>  block.c |    1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Eric Blake <ebl...@redhat.com>

> 
> diff --git a/block.c b/block.c
> index 76a6621..4922fb9 100644
> --- a/block.c
> +++ b/block.c
> @@ -3149,6 +3149,7 @@ static int64_t coroutine_fn 
> bdrv_co_get_block_status(BlockDriverState *bs,
>  
>      ret = bs->drv->bdrv_co_get_block_status(bs, sector_num, nb_sectors, 
> pnum);
>      if (ret < 0) {
> +        *pnum = 0;
>          return ret;
>      }
>  
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to