Am 06.09.2013 um 17:52 hat Max Reitz geschrieben: > This RFC adds an Error ** parameter to bdrv_open, bdrv_file_open, > bdrv_create and the respective functions provided by a block driver. > > This results in more specific error information than just -errno provided > to the user when opening or creating images (disregarding the fact that > block drivers often already use error_report, which is generally changed > to error_setg through this patch). > > The sixth patch in this series changes the qcow2 block driver to set an > example of usage in a block driver. > > Note that several I/O tests break by applying this RFC since they expect > different error messages (generally, previously, an error message on > image opening/creation consisted of two lines; the first of which would be > generated by the driver through error_report, the second by the block > layer itself through strerror(-ret); this patch is designed to merge these > two lines into a single one). This applies to the tests 49, 51, 54 and 60.
Looks good to me now (except that it needs a rebase because it conflicts with other recent patches in the block tree). I guess it's time to address the qemu-iotests part and send out a non-RFC series. Kevin
